Closed
Conversation
Contributor
Greptile SummaryReplaced external Major Changes:
Critical Issue Found:
Confidence Score: 2/5
Important Files Changed
Last reviewed commit: f8ecc87 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const parent = resolve(resolved, '..') | ||
| try { | ||
| const realParent = await realpath(parent) | ||
| if (!realParent.startsWith(realCwd) && realParent !== realCwd) { |
Contributor
There was a problem hiding this comment.
Path traversal vulnerability: startsWith check doesn't validate path separator, allowing access to sibling directories with matching prefixes.
Example attack:
- cwd:
/tmp/safe - path:
../safe-evil/malicious.txt - Result:
/tmp/safe-evil/malicious.txt.startsWith(/tmp/safe) →true✗
Fix: import sep from node:path and check for separator after prefix:
Suggested change
| if (!realParent.startsWith(realCwd) && realParent !== realCwd) { | |
| if (!realParent.startsWith(realCwd + sep) && realParent !== realCwd) { |
Also apply same fix to lines 40 and 46.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/server/src/tools/filesystem/path-utils.ts
Line: 27
Comment:
Path traversal vulnerability: `startsWith` check doesn't validate path separator, allowing access to sibling directories with matching prefixes.
Example attack:
- cwd: `/tmp/safe`
- path: `../safe-evil/malicious.txt`
- Result: `/tmp/safe-evil/malicious.txt`.startsWith(`/tmp/safe`) → `true` ✗
Fix: import `sep` from `node:path` and check for separator after prefix:
```suggestion
if (!realParent.startsWith(realCwd + sep) && realParent !== realCwd) {
```
Also apply same fix to lines 40 and 46.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.